Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add GPTNeoXForSequenceClassification #22671

Merged
merged 3 commits into from
Apr 10, 2023
Merged

add GPTNeoXForSequenceClassification #22671

merged 3 commits into from
Apr 10, 2023

Conversation

Asugawara
Copy link
Contributor

What does this PR do?

This PR adds the GPTNeoX Seq Classification.
Would you be able to check them?

In advance, thank you for this cool OSS!

ref: #11906

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@sgugger
@ArthurZucker
@younesbelkada

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 8, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

younesbelkada
younesbelkada approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this contribution! This looks clean to me

@Asugawara Asugawara force-pushed the add_gptneox_seq_classification branch from e6ded3c to 2eef5c2 Compare April 10, 2023 12:34
sgugger
sgugger approved these changes Apr 10, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this new model!

src/transformers/models/gpt_neox/modeling_gpt_neox.py Show resolved Hide resolved
@sgugger sgugger merged commit 6daa9cb into huggingface:main Apr 10, 2023
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
@Asugawara @novice03
add GPTNeoXForSequenceClassification (huggingface#22671)
1af81ee 
* add GPTNeoXForSequenceClassification

* move the labels to logits.device (ref: huggingface#22561)

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

@younesbelkada younesbelkada younesbelkada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Asugawara @HuggingFaceDocBuilderDev @sgugger @younesbelkada